Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1192573003: Add and use SkSemaphore (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add and use SkSemaphore This allows a faster implementation of our SkTaskGroup thread pool. It also means we don't need SkCondVar (which, remember, isn't supported on XP.) Doing some testing with SampleApp, this really cuts down on the overhead from SkTaskGroup, e.g. 30% to 10%. BUG=skia: Committed: https://skia.googlesource.com/skia/+/61fa22be104a3e98998fa1b24cd47b886df5721c

Patch Set 1 #

Patch Set 2 : Implement thread pool with SkSemaphore, removing SkCondVar. #

Patch Set 3 : comments #

Patch Set 4 : all platforms #

Patch Set 5 : build fixes #

Patch Set 6 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -210 lines) Patch
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/utils.gypi View 1 1 chunk +0 lines, -5 lines 0 comments Download
A src/core/SkSemaphore.h View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
A src/core/SkSemaphore.cpp View 1 2 3 4 1 chunk +86 lines, -0 lines 0 comments Download
M src/core/SkTaskGroup.cpp View 1 2 3 4 5 7 chunks +47 lines, -28 lines 0 comments Download
D src/utils/SkCondVar.h View 1 1 chunk +0 lines, -74 lines 0 comments Download
D src/utils/SkCondVar.cpp View 1 1 chunk +0 lines, -103 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192573003/60001
5 years, 6 months ago (2015-06-17 16:16:21 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192573003/80001
5 years, 6 months ago (2015-06-17 16:18:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 16:29:57 UTC) #6
mtklein_C
5 years, 6 months ago (2015-06-17 16:30:33 UTC) #8
bungeman-skia
lgtm
5 years, 6 months ago (2015-06-17 17:44:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192573003/100001
5 years, 6 months ago (2015-06-17 17:44:43 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 17:50:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/61fa22be104a3e98998fa1b24cd47b886df5721c

Powered by Google App Engine
This is Rietveld 408576698