Don't call bindTexture from GrGLProgram

Don't call bindTexture from GrGLProgram

Updates GrGLProgram to tell the gpu object which textures it wants
bound, instead of calling bindTexture directly. This begins to break
its dependence on the specific GrGLGpu object.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4271765d110be2661562f30f47addc9cb69ca4c7

[Chris Dalton, 2015-06-16 20:26:53]

cdalton@nvidia.com changed reviewers:
+ bsalomon@google.com

[Chris Dalton, 2015-06-16 20:26:54]

Curious to hear what you think about this approach. I thought I liked it better
than some sort of virtual bind method. Plus, texture bindings are global state
not owned by the program, so I think it makes sense to not be setting it inside
there.

[bsalomon, 2015-06-16 20:31:05]

bsalomon@google.com changed reviewers:
+ joshualitt@google.com

[bsalomon, 2015-06-16 20:31:06]

+Josh

[jvanverth1, 2015-06-18 13:46:45]

jvanverth@google.com changed reviewers:
+ jvanverth@google.com

[joshualitt, 2015-06-18 15:51:27]

mostly looks good, just a really minor nit.

https://codereview.chromium.org/1192463003/diff/20001/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/1192463003/diff/20001/src/gpu/gl/GrGLProgram....
src/gpu/gl/GrGLProgram.cpp:80: } while (++i < numTextures);
why not just a regular for loop?

[Chris Dalton, 2015-06-18 18:13:51]

https://codereview.chromium.org/1192463003/diff/20001/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/1192463003/diff/20001/src/gpu/gl/GrGLProgram....
src/gpu/gl/GrGLProgram.cpp:80: } while (++i < numTextures);
On 2015/06/18 15:51:27, joshualitt wrote:
> why not just a regular for loop?

Philosophical reasons I guess. No need for a top tested loop since we already
know numTextures != 0.

I don't care much either way though if you'd prefer a for loop.

[joshualitt, 2015-06-18 18:34:28]

On 2015/06/18 18:13:51, Chris Dalton wrote:
>
https://codereview.chromium.org/1192463003/diff/20001/src/gpu/gl/GrGLProgram.cpp
> File src/gpu/gl/GrGLProgram.cpp (right):
> 
>
https://codereview.chromium.org/1192463003/diff/20001/src/gpu/gl/GrGLProgram....
> src/gpu/gl/GrGLProgram.cpp:80: } while (++i < numTextures);
> On 2015/06/18 15:51:27, joshualitt wrote:
> > why not just a regular for loop?
> 
> Philosophical reasons I guess. No need for a top tested loop since we already
> know numTextures != 0.
> 
> I don't care much either way though if you'd prefer a for loop.
That makes sense.

lgtm

[Chris Dalton, 2015-06-18 18:46:58]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2015-06-18 18:47:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1192463003/20001

[commit-bot: I haz the power, 2015-06-18 18:47:27]

The author cdalton@nvidia.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[commit-bot: I haz the power, 2015-06-18 18:54:34]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4271765d110be2661562f30f47addc9cb69ca4c7