Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 119243: Adding an ifdef that forces wchar_t into PRUint16 temporarily on a nsAString ... (Closed)

Created:
11 years, 6 months ago by robertshield
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adding an ifdef that forces wchar_t into PRUint16 temporarily on a nsAString method in order to allow linking from projects that don't have the /Zc:wchar_t- flag set. BUG=none TEST=can link with xulrunner libs from a project using the /Zc:wchar_t flag. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17887

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M third_party/xulrunner-sdk/win/include/xpcom/nsStringAPI.h View 1 3 chunks +12 lines, -0 lines 0 comments Download
M third_party/xulrunner-sdk/win/sdk/include/nsStringAPI.h View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
robertshield
This is ugly, real ugly. Without rebuilding or wrapping the sdk, it seems like the ...
11 years, 6 months ago (2009-06-05 14:42:42 UTC) #1
tommi (sloooow) - chröme
trybots seem to be complaining. if that's not due to this change, lgtm.
11 years, 6 months ago (2009-06-05 16:34:27 UTC) #2
amit
lgtm, with a QQ. http://codereview.chromium.org/119243/diff/1/2 File third_party/xulrunner-sdk/win/sdk/include/nsStringAPI.h (right): http://codereview.chromium.org/119243/diff/1/2#newcode67 Line 67: #define char_type PRUint16 if ...
11 years, 6 months ago (2009-06-05 17:35:12 UTC) #3
robertshield
http://codereview.chromium.org/119243/diff/1/2 File third_party/xulrunner-sdk/win/sdk/include/nsStringAPI.h (right): http://codereview.chromium.org/119243/diff/1/2#newcode67 Line 67: #define char_type PRUint16 On 2009/06/05 17:35:12, amit wrote: ...
11 years, 6 months ago (2009-06-08 18:50:35 UTC) #4
robertshield
On 2009/06/05 16:34:27, tommi wrote: > trybots seem to be complaining. if that's not due ...
11 years, 6 months ago (2009-06-08 19:03:15 UTC) #5
tommi (sloooow) - chröme
11 years, 6 months ago (2009-06-08 19:09:02 UTC) #6
lgtm

On 2009/06/08 19:03:15, robertshield wrote:
> On 2009/06/05 16:34:27, tommi wrote:
> > trybots seem to be complaining.  if that's not due to this change, lgtm.
> 
> re. trybots, turns out the chromium trybots don't load this SDK so they can't
> patch the change in. No biggy since they don't build against it anyway.

Powered by Google App Engine
This is Rietveld 408576698