Adding an ifdef that forces wchar_t into PRUint16 temporarily on a nsAString ...

Adding an ifdef that forces wchar_t into PRUint16 temporarily on a nsAString method in order to allow linking from projects that don't have the /Zc:wchar_t- flag set.

BUG=none
TEST=can link with xulrunner libs from a project using the /Zc:wchar_t flag.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17887

[robertshield, 2009-06-05 14:42:42]

This is ugly, real ugly. Without rebuilding or wrapping the sdk, it seems like
the easiest thing to do though.

[tommi (sloooow) - chröme, 2009-06-05 16:34:27]

trybots seem to be complaining.  if that's not due to this change, lgtm.

[amit, 2009-06-05 17:35:12]

lgtm, with a QQ.

http://codereview.chromium.org/119243/diff/1/2
File third_party/xulrunner-sdk/win/sdk/include/nsStringAPI.h (right):

http://codereview.chromium.org/119243/diff/1/2#newcode67
Line 67: #define char_type PRUint16
if this is a windows only issues should we wrap it inside #ifdef OS_WINDOWS (or
whatever we use for windows)?

[robertshield, 2009-06-08 18:50:35]

http://codereview.chromium.org/119243/diff/1/2
File third_party/xulrunner-sdk/win/sdk/include/nsStringAPI.h (right):

http://codereview.chromium.org/119243/diff/1/2#newcode67
Line 67: #define char_type PRUint16
On 2009/06/05 17:35:12, amit wrote:
> if this is a windows only issues should we wrap it inside #ifdef OS_WINDOWS
(or
> whatever we use for windows)?

Yes, we should.PRUnichar is defined as:

#if defined(WIN32) || defined(XP_MAC)
typedef wchar_t PRUnichar;
#else
typedef PRUint16 PRUnichar;
#endif


When I read that initially, I didn't parse the XP_MAC clause properly and
thought this would be a no-op on any non-windows platforms. I've now wrapped
this properly in ifdefs.

[robertshield, 2009-06-08 19:03:15]

On 2009/06/05 16:34:27, tommi wrote:
> trybots seem to be complaining.  if that's not due to this change, lgtm.

re. trybots, turns out the chromium trybots don't load this SDK so they can't
patch the change in. No biggy since they don't build against it anyway.

[tommi (sloooow) - chröme, 2009-06-08 19:09:02]

lgtm

On 2009/06/08 19:03:15, robertshield wrote:
> On 2009/06/05 16:34:27, tommi wrote:
> > trybots seem to be complaining.  if that's not due to this change, lgtm.
> 
> re. trybots, turns out the chromium trybots don't load this SDK so they can't
> patch the change in. No biggy since they don't build against it anyway.