Avoid checking of VerifyPassword() 2 times when generated password is proper.

Avoid checking of VerifyPassword() 2 times when generated password is proper.

Currently when generated password is proper then also it is getting checked 2 times. it can be avoided by returning the password when generated password in proper.

BUG=503041
Committed: https://crrev.com/13fff641ca5c841c9f0a3f0d7c461cdfe2ea03b2
Cr-Commit-Position: refs/heads/master@{#335614}

[Deepak, 2015-06-22 09:22:57]

deepak.m1@samsung.com changed reviewers:
+ ajith.v@chromium.org

[Deepak, 2015-06-22 09:22:58]

PTAL

[AKV, 2015-06-22 09:39:18]

https://codereview.chromium.org/1192403003/diff/1/components/autofill/core/br...
File components/autofill/core/browser/password_generator.cc (right):

https://codereview.chromium.org/1192403003/diff/1/components/autofill/core/br...
components/autofill/core/browser/password_generator.cc:92: // |ForceFixPassword|
as lowercase letters are default in generated password.
Can we reduce this password generation loop further down, instead of skipping it
in first attempt ?
Could you please start a discussion thread on this scope ?

https://codereview.chromium.org/1192403003/diff/1/components/autofill/core/br...
components/autofill/core/browser/password_generator.cc:96: return
std::string(password);
Looks legitimate.

[Deepak, 2015-06-22 10:50:31]

deepak.m1@samsung.com changed reviewers:
+ gcasto@chromium.org, vabr@chromium.org

[Deepak, 2015-06-22 10:50:32]

PTAL.

https://codereview.chromium.org/1192403003/diff/1/components/autofill/core/br...
File components/autofill/core/browser/password_generator.cc (right):

https://codereview.chromium.org/1192403003/diff/1/components/autofill/core/br...
components/autofill/core/browser/password_generator.cc:92: // |ForceFixPassword|
as lowercase letters are default in generated password.
On 2015/06/22 09:39:18, AKV wrote:
> Can we reduce this password generation loop further down, instead of skipping
it
> in first attempt ?
> Could you please start a discussion thread on this scope ?

ok, I will raise the bug and discuss this.

https://codereview.chromium.org/1192403003/diff/1/components/autofill/core/br...
components/autofill/core/browser/password_generator.cc:96: return
std::string(password);
On 2015/06/22 09:39:18, AKV wrote:
> Looks legitimate.

Done.

[Deepak, 2015-06-22 10:53:42]

PTAL

[AKV, 2015-06-22 11:45:48]

peer review looks good to me!

[Deepak, 2015-06-22 11:48:29]

owners PTAL.
Thanks

[Garrett Casto, 2015-06-22 23:27:47]

lgtm

[Deepak, 2015-06-23 02:45:16]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-06-23 02:45:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1192403003/20001

[commit-bot: I haz the power, 2015-06-23 02:50:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-23 02:51:47]

Patchset 2 (id:??) landed as
https://crrev.com/13fff641ca5c841c9f0a3f0d7c461cdfe2ea03b2
Cr-Commit-Position: refs/heads/master@{#335614}