Avoid checking of VerifyPassword() 2 times when generated password is proper.

components/autofill/core/browser/password_generator.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/password_generator.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 70 matching lines @@
 PasswordGenerator::~PasswordGenerator() {}
 
 std::string PasswordGenerator::Generate() const {
   char password[255];
   char unused_hypenated_password[255];
   // Generate passwords that have numbers and upper and lower case letters.
   // No special characters included for now.
   unsigned int mode = S_NB | S_CL | S_SL;
 
   // gen_pron_pass() doesn't guarantee that it includes all of the type given
-  // in mode, so regenerate a few times if neccessary.
-  // TODO(gcasto): Is it worth regenerating at all?
-  for (int i = 0; i < 10; ++i) {
-    gen_pron_pass(password, unused_hypenated_password,
-                  password_length_, password_length_, mode);
-    if (VerifyPassword(password))
-      break;
-  }
+  // in mode, so if generated password is not proper we will force fix this by
+  // |ForceFixPassword| as lowercase letters are default in generated password.

[AKV, 2015/06/22 09:39:18]

Can we reduce this password generation loop further down, instead of skipping it
in first attempt ?
Could you please start a discussion thread on this scope ?

[Deepak, 2015/06/22 10:50:31]

ok, I will raise the bug and discuss this.

+  gen_pron_pass(password, unused_hypenated_password, password_length_,
+                password_length_, mode);
+  if (VerifyPassword(password))
+    return std::string(password);

[AKV, 2015/06/22 09:39:18]

Looks legitimate.

[Deepak, 2015/06/22 10:50:31]

Done.

 
-  // If the password still isn't conforming after a few iterations, force it
-  // to be so. This may change a syllable in the password.
+  // As the password isn't conforming force it to be so. This may change a
+  // syllable in the password.
   std::string str_password(password);
-  if (!VerifyPassword(str_password)) {
-    ForceFixPassword(&str_password);
-  }
+  ForceFixPassword(&str_password);
   return str_password;
 }
 
 }  // namespace autofill