chrome/browser/ui/omnibox/omnibox_controller.cc - Issue 1192373002: Prepare AutocompleteController for componentization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_controller.cc

Issue 1192373002: Prepare AutocompleteController for componentization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@componentize_zero_suggest_provider

Patch Set: Response to review Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/search/omnibox_provider.cc ('k') | chrome/browser/ui/views/frame/test_with_browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_controller.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_controller.cc b/chrome/browser/ui/omnibox/omnibox_controller.cc

index 9876ae361dcf3c9f0faa1033601a09b706f94d9e..d90c0f7bbda2a8e3643a12688074c0e4e729d330 100644

--- a/chrome/browser/ui/omnibox/omnibox_controller.cc

+++ b/chrome/browser/ui/omnibox/omnibox_controller.cc

@@ -6,6 +6,7 @@

#include "base/metrics/histogram.h"

#include "chrome/browser/autocomplete/autocomplete_classifier.h"

+#include "chrome/browser/autocomplete/chrome_autocomplete_provider_client.h"

#include "chrome/browser/bitmap_fetcher/bitmap_fetcher_service_factory.h"

#include "chrome/browser/net/predictor.h"

#include "chrome/browser/predictors/autocomplete_action_predictor.h"

@@ -101,8 +102,7 @@ OmniboxController::OmniboxController(OmniboxEditModel* omnibox_edit_model,

profile_(profile),

popup_(NULL),

autocomplete_controller_(new AutocompleteController(

- profile,

- TemplateURLServiceFactory::GetForProfile(profile),

+ make_scoped_ptr(new ChromeAutocompleteProviderClient(profile)),

this,

AutocompleteClassifier::kDefaultOmniboxProviders)),

request_id_(BitmapFetcherService::REQUEST_ID_INVALID),

« no previous file with comments | « chrome/browser/ui/app_list/search/omnibox_provider.cc ('k') | chrome/browser/ui/views/frame/test_with_browser_view.cc » ('j') | no next file with comments »