chrome/browser/ui/app_list/search/omnibox_provider.cc - Issue 1192373002: Prepare AutocompleteController for componentization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/omnibox_provider.cc

Issue 1192373002: Prepare AutocompleteController for componentization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@componentize_zero_suggest_provider

Patch Set: Response to review Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/app_list/search/omnibox_provider.cc

diff --git a/chrome/browser/ui/app_list/search/omnibox_provider.cc b/chrome/browser/ui/app_list/search/omnibox_provider.cc

index b6fb5fb919068b7a27f273f4b2e20bc8393604b7..928636102e891558868f75eafbc46c61f47250d0 100644

--- a/chrome/browser/ui/app_list/search/omnibox_provider.cc

+++ b/chrome/browser/ui/app_list/search/omnibox_provider.cc

@@ -6,6 +6,7 @@

#include "chrome/browser/autocomplete/autocomplete_classifier.h"

#include "chrome/browser/autocomplete/autocomplete_controller.h"

+#include "chrome/browser/autocomplete/chrome_autocomplete_provider_client.h"

#include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/search_engines/template_url_service_factory.h"

@@ -23,8 +24,7 @@ OmniboxProvider::OmniboxProvider(Profile* profile,

: profile_(profile),

list_controller_(list_controller),

controller_(new AutocompleteController(

- profile,

- TemplateURLServiceFactory::GetForProfile(profile),

+ make_scoped_ptr(new ChromeAutocompleteProviderClient(profile)),

this,

AutocompleteClassifier::kDefaultOmniboxProviders &

~AutocompleteProvider::TYPE_ZERO_SUGGEST)),

« no previous file with comments | « chrome/browser/autocomplete/search_provider_unittest.cc ('k') | chrome/browser/ui/omnibox/omnibox_controller.cc » ('j') | no next file with comments »