Chromium Code Reviews Chromium Code Reviews
Issue
1192363006:
Update reader mode viewer according to specs (Closed)
DescriptionUpdate reader mode viewer according to specs
Also add a filler viewer for easier CSS visualization, with language family
selection.
Specs of reader mode:
https://code.google.com/p/chromium/issues/detail?id=428533#c24
Main changes according to the spec:
- Use Roboto font for sans-serif.
- Remove the gray background of title area.
- Adjust color, line-height, padding, and margin of many elements.
- Change max-width for wide screen, with consideration of pinch-to-zoom.
Other changes:
- Fix wrapping in <pre>.
- Handle <code> in <pre> properly.
- Disable the animation when setting the title.
- Tune colors for three themes (light, dark, sepia).
BUG=428533, 499740
Committed: https://crrev.com/4614086549d43ecc432ffa6bb6047abd2d5eba88
Cr-Commit-Position: refs/heads/master@{#338368}
Patch Set 1 #
Total comments: 4
Patch Set 2 : address chris' comment #Patch Set 3 : add tall and dense languages #Patch Set 4 : fix line height #Patch Set 5 : rename, heading, table, img adjustments #Patch Set 6 : limit paragraph width and img left-align #Patch Set 7 : table style, gray subtitle, color for closeview #Patch Set 8 : subtitle color, table cell padding, simplify striped table color, wide table scrolling #
Messages
Total messages: 16 (4 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
