Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1192323002: Cleanup: Remove experimental V8 cache strategies that we discarded. (Closed)

Created:
5 years, 6 months ago by vogelheim
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove experimental V8 cache strategies that we discarded. Remaining are only: - none (all off), - parse (formerly parse-memory, the pre-M43 default) - code (formerly heuristics, the new default) - default (whatever we think is best. We think "code" is best.) blink companion CL is forthcoming, and will be submitted right afterwards. BUG=455187, 399580 Committed: https://crrev.com/9ef1576fb4204023cd78584175bf4a375483c498 Cr-Commit-Position: refs/heads/master@{#335652}

Patch Set 1 #

Patch Set 2 : Add #if-guard for multi-CL change. #

Patch Set 3 : Fix ServiceWorkerVersionBrowserV8CacheTest. #

Patch Set 4 : Also fix EmbeddedWorkerBrowserTest. #

Patch Set 5 : Better comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -49 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M content/common/content_switches_internal.cc View 1 chunk +3 lines, -19 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +2 lines, -10 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 1 chunk +7 lines, -20 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.cc View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M content/test/data/service_worker/worker.js View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vogelheim
5 years, 6 months ago (2015-06-19 16:18:36 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-22 08:33:31 UTC) #3
vogelheim
Hi horo, This CL is meant to clean up some of my code caching work, ...
5 years, 6 months ago (2015-06-22 14:09:01 UTC) #5
horo
lgtm
5 years, 6 months ago (2015-06-23 01:52:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192323002/80001
5 years, 6 months ago (2015-06-23 08:20:45 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 6 months ago (2015-06-23 09:55:23 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 09:56:23 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9ef1576fb4204023cd78584175bf4a375483c498
Cr-Commit-Position: refs/heads/master@{#335652}

Powered by Google App Engine
This is Rietveld 408576698