Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 1192323002: Cleanup: Remove experimental V8 cache strategies that we discarded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/content_switches_internal.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index 95d3c1af38ccddb286eac28fb6b6b13e4a77cd3b..b22914050e6a6937e1126163ae2990268d1ead7f 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -362,6 +362,14 @@ class EmbeddedWorkerBrowserTest : public ServiceWorkerBrowserTest,
}
}
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ ServiceWorkerBrowserTest::SetUpCommandLine(command_line);
+
+ // Code caching requires a bit more infrastructure that we don't care
+ // about in this test.
+ command_line->AppendSwitchASCII(switches::kV8CacheOptions, "none");
+ }
+
void StartOnIOThread() {
ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));
worker_ = wrapper()->context()->embedded_worker_registry()->CreateWorker();
@@ -383,6 +391,7 @@ class EmbeddedWorkerBrowserTest : public ServiceWorkerBrowserTest,
pause_mode_ != DONT_PAUSE,
base::Bind(&EmbeddedWorkerBrowserTest::StartOnIOThread2, this));
}
+
void StartOnIOThread2(ServiceWorkerStatusCode status) {
last_worker_status_ = worker_->status();
EXPECT_EQ(SERVICE_WORKER_OK, status);
« no previous file with comments | « no previous file | content/common/content_switches_internal.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698