Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1191983002: DevTools: [Console] filter out URLs from %c styling properties (Closed)

Created:
5 years, 6 months ago by lushnikov
Modified:
5 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: [Console] filter out URLs from %c styling properties Filter out properties from %c console message styling which value starts with 'url('. BUG=495643 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197345

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M LayoutTests/inspector/console/console-format-style-whitelist.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-format-style-whitelist-expected.txt View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 6 (1 generated)
lushnikov
5 years, 6 months ago (2015-06-17 18:48:15 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/1191983002/diff/1/Source/devtools/front_end/console/ConsoleViewMessage.js File Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/1191983002/diff/1/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode796 Source/devtools/front_end/console/ConsoleViewMessage.js:796: if (!value.startsWith("url(") && isWhitelistedProperty(property)) includes( or trim( instead?
5 years, 6 months ago (2015-06-18 06:49:01 UTC) #2
lushnikov
https://codereview.chromium.org/1191983002/diff/1/Source/devtools/front_end/console/ConsoleViewMessage.js File Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/1191983002/diff/1/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode796 Source/devtools/front_end/console/ConsoleViewMessage.js:796: if (!value.startsWith("url(") && isWhitelistedProperty(property)) On 2015/06/18 06:49:01, pfeldman wrote: ...
5 years, 6 months ago (2015-06-18 10:27:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191983002/1
5 years, 6 months ago (2015-06-18 10:28:13 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 11:47:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197345

Powered by Google App Engine
This is Rietveld 408576698