Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 1191983002: DevTools: [Console] filter out URLs from %c styling properties (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/console/console-format-style-whitelist-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/Source/devtools/front_end/console/ConsoleViewMessage.js b/Source/devtools/front_end/console/ConsoleViewMessage.js
index 340dfe962aa848cf740d8db8313142f7c0a5de72..7ff27bd73bbaf50af85b42a4c889662bd8cd57c4 100644
--- a/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -792,7 +792,8 @@ WebInspector.ConsoleViewMessage.prototype = {
buffer.setAttribute("style", obj.description);
for (var i = 0; i < buffer.style.length; i++) {
var property = buffer.style[i];
- if (isWhitelistedProperty(property))
+ var value = buffer.style.getPropertyValue(property);
+ if (!value.startsWith("url(") && isWhitelistedProperty(property))
pfeldman 2015/06/18 06:49:01 includes( or trim( instead?
lushnikov 2015/06/18 10:27:55 We have CSSOM property values here; no need for tr
currentStyle[property] = buffer.style[property];
}
}
« no previous file with comments | « LayoutTests/inspector/console/console-format-style-whitelist-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698