Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1191373005: Revert of Add d8 API for spawning function on a new thread (Second try) (Closed)

Created:
5 years, 6 months ago by binji
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add d8 API for spawning function on a new thread (Second try) (patchset #3 id:60001 of https://codereview.chromium.org/1195613003/) Reason for revert: Fails on V8 Linux - isolates (http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20isolates/builds/4128) Original issue's description: > Add d8 API for spawning function on a new thread (Second try) > > This API closely matches the Worker API. The differences: > > 1) The argument to the Worker constructor is a function to run, not a script. > 2) Receiving a message from a worker is a synchronous API (as there is no event > loop). > > The serialization done here is not robust as the real DOM implementation. For > example, recursive data structures or otherwise duplicated objects are not > allowed. > > BUG=chromium:497295 > R=jochen@chromium.org > LOG=n > > Review URL: https://codereview.chromium.org/1185643004 > > Cr-Commit-Position: refs/heads/master@{#29126} > > Committed: https://crrev.com/ec2eaf712ecee6b4891c0458f2397e04a1f9b339 > Cr-Commit-Position: refs/heads/master@{#29158} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:497295 Committed: https://crrev.com/4f8761ca4e9c5ac89e787caeabf4fb27814424fc Cr-Commit-Position: refs/heads/master@{#29161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -858 lines) Patch
M src/d8.h View 6 chunks +0 lines, -122 lines 0 comments Download
M src/d8.cc View 11 chunks +8 lines, -602 lines 0 comments Download
D test/mjsunit/d8-worker.js View 1 chunk +0 lines, -134 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
binji
Created Revert of Add d8 API for spawning function on a new thread (Second try)
5 years, 6 months ago (2015-06-19 18:31:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191373005/1
5 years, 6 months ago (2015-06-19 18:32:06 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-19 18:32:10 UTC) #4
adamk
lgtm
5 years, 6 months ago (2015-06-19 18:33:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191373005/1
5 years, 6 months ago (2015-06-19 18:33:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 18:34:02 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 18:34:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f8761ca4e9c5ac89e787caeabf4fb27814424fc
Cr-Commit-Position: refs/heads/master@{#29161}

Powered by Google App Engine
This is Rietveld 408576698