Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 119133003: Make InputMethodEngine manage its descriptor. (Closed)

Created:
7 years ago by Hiro Komatsu
Modified:
6 years, 11 months ago
Reviewers:
yoichio, Seigo Nonaka
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, Jun Mukai
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Refactoring around descriptor. The descriptor representing InputMethodEngine was previously generated in InpuMethodManager. This patch makes InputMethodEngine generates its own descriptor and manage it. BUG=N/A Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243763

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -156 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine.h View 4 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 2 chunks +22 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_interface.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 6 chunks +46 lines, -51 lines 0 comments Download
A + chrome/browser/chromeos/input_method/mock_input_method_engine.h View 3 chunks +12 lines, -61 lines 0 comments Download
A chrome/browser/chromeos/input_method/mock_input_method_engine.cc View 1 chunk +155 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/ime/input_method_manager.h View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Hiro Komatsu
6 years, 11 months ago (2014-01-08 04:45:04 UTC) #1
yoichio
6 years, 11 months ago (2014-01-08 08:19:36 UTC) #2
yoichio
6 years, 11 months ago (2014-01-08 08:19:36 UTC) #3
yoichio
lgtm
6 years, 11 months ago (2014-01-08 08:19:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/119133003/220001
6 years, 11 months ago (2014-01-08 09:02:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git, ...
6 years, 11 months ago (2014-01-08 09:10:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/119133003/220001
6 years, 11 months ago (2014-01-09 02:21:55 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 04:26:33 UTC) #8
Message was sent while issue was closed. 
Change committed as 243763

Powered by Google App Engine
This is Rietveld 408576698