Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3282)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.cc

Issue 119133003: Make InputMethodEngine manage its descriptor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_manager_impl.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
index b9f307f3b065a4ff1c0c05f5dc3ba6ab2e5ce65e..0b710197fe7f61bc274c1b28af164e265b91c07b 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
@@ -420,11 +420,6 @@ void InputMethodManagerImpl::ActivateInputMethodProperty(
void InputMethodManagerImpl::AddInputMethodExtension(
const std::string& id,
- const std::string& name,
- const std::vector<std::string>& layouts,
- const std::vector<std::string>& languages,
- const GURL& options_url,
- const GURL& inputview_url,
InputMethodEngineInterface* engine) {
if (state_ == STATE_TERMINATING)
return;
@@ -435,15 +430,17 @@ void InputMethodManagerImpl::AddInputMethodExtension(
return;
}
- extra_input_methods_[id] = InputMethodDescriptor(
- id, name, layouts, languages, false, options_url, inputview_url);
+ DCHECK(engine);
+
+ const InputMethodDescriptor& descriptor = engine->GetDescriptor();
+ extra_input_methods_[id] = descriptor;
if (Contains(enabled_extension_imes_, id) &&
!extension_ime_util::IsComponentExtensionIME(id)) {
if (!Contains(active_input_method_ids_, id)) {
active_input_method_ids_.push_back(id);
} else {
DVLOG(1) << "AddInputMethodExtension: alread added: "
- << id << ", " << name;
+ << id << ", " << descriptor.name();
// Call Start() anyway, just in case.
}
@@ -451,9 +448,7 @@ void InputMethodManagerImpl::AddInputMethodExtension(
MaybeInitializeCandidateWindowController();
}
- // TODO(komatsu): Engine should not be NULL even in unittests.
- if (engine)
- IBusBridge::Get()->SetEngineHandler(id, engine);
+ IBusBridge::Get()->SetEngineHandler(id, engine);
}
void InputMethodManagerImpl::RemoveInputMethodExtension(const std::string& id) {

Powered by Google App Engine
This is Rietveld 408576698