Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1191313003: More cleanup related to setting array.length (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

More cleanup related to setting array.length BUG= Committed: https://crrev.com/8076d6ee2de830b6c8be3cefdbdd5d3fa448075e Cr-Commit-Position: refs/heads/master@{#29152}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Should actually save before commit ... :) #

Patch Set 6 : DCHECK+Smi::kMaxValue == fail #

Patch Set 7 : #

Total comments: 1

Patch Set 8 : damn compiler #

Patch Set 9 : #

Patch Set 10 : Compiler error #

Patch Set 11 : Restore fast path #

Patch Set 12 : Addressed comment #

Patch Set 13 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -147 lines) Patch
M src/accessors.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -1 line 0 comments Download
M src/ast.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/elements.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/elements.cc View 1 2 3 4 5 6 7 8 12 chunks +67 lines, -94 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +7 lines, -7 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +15 lines, -21 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 6 1 chunk +5 lines, -7 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-19 11:40:55 UTC) #2
Jakob Kummerow
LGTM with a naming nit. https://codereview.chromium.org/1191313003/diff/120001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1191313003/diff/120001/src/objects.cc#newcode11941 src/objects.cc:11941: MaybeHandle<Object> JSArray::ObserveableSetLength(Handle<JSArray> array, nit: ...
5 years, 6 months ago (2015-06-19 13:23:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191313003/220001
5 years, 6 months ago (2015-06-19 13:25:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191313003/240001
5 years, 6 months ago (2015-06-19 13:58:24 UTC) #9
commit-bot: I haz the power
Committed patchset #13 (id:240001)
5 years, 6 months ago (2015-06-19 14:57:03 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 14:57:21 UTC) #11
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/8076d6ee2de830b6c8be3cefdbdd5d3fa448075e
Cr-Commit-Position: refs/heads/master@{#29152}

Powered by Google App Engine
This is Rietveld 408576698