src/ast.cc - Issue 1191313003: More cleanup related to setting array.length

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 1191313003: More cleanup related to setting array.length (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index c9e4c0f21974a8983024e4bc0b4f1415cccc87e1..31cfee3cac72783cac74aab5d18f1f149ca2b187 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -557,8 +557,7 @@ void ArrayLiteral::BuildConstantElements(Isolate* isolate) {

}

if (array_index != values()->length()) {

- JSArray::SetElementsLength(

- array, handle(Smi::FromInt(array_index), isolate)).Assert();

+ JSArray::SetLength(array, array_index);

}

Handle<FixedArrayBase> element_values(array->elements());

« no previous file with comments | « src/accessors.cc ('k') | src/builtins.cc » ('j') | no next file with comments »