[turbofan] Factor out the function specific part from the frame state operator.

[turbofan] Factor out the function specific part from the frame state operator.

This also threads through the parameter count and local count to the instruction selector. This will be later used to allow merging of various StateValues vector (and prepare for differential encoding which will not distinguish between parameters, locals and expression stack).

BUG=

Committed: https://crrev.com/de62b486e35c565639878b6e7d81e21bccac497c
Cr-Commit-Position: refs/heads/master@{#29214}

[Jarin, 2015-06-22 11:48:56]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2015-06-22 12:14:36]

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:452: FrameStateType::kJavaScriptFunction,
info->num_parameters() + 1,
Nit: Use info->num_parameters_including_this() here?

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/common-ope...
File src/compiler/common-operator.cc (right):

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/common-ope...
src/compiler/common-operator.cc:782: return new
(zone()->New(sizeof(FrameStateFunctionInfo)))
Turn the FrameStateFunctionInfo into a ZoneObject and avoid placement new here?

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/frame-stat...
File src/compiler/frame-states.cc (right):

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/frame-stat...
src/compiler/frame-states.cc:32: lhs.state_combine() == rhs.state_combine();
I guess we also need lhs.info() == rhs.info() here.

[Jarin, 2015-06-22 12:14:44]

Could you take a look, please?

[Jarin, 2015-06-22 12:14:47]

Could you take a look, please?

[Benedikt Meurer, 2015-06-23 02:28:26]

LGTM once comments/nits are addressed.

[Jarin, 2015-06-23 07:13:40]

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:452: FrameStateType::kJavaScriptFunction,
info->num_parameters() + 1,
On 2015/06/22 12:14:35, Benedikt Meurer wrote:
> Nit: Use info->num_parameters_including_this() here?

Done.

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/common-ope...
File src/compiler/common-operator.cc (right):

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/common-ope...
src/compiler/common-operator.cc:782: return new
(zone()->New(sizeof(FrameStateFunctionInfo)))
On 2015/06/22 12:14:35, Benedikt Meurer wrote:
> Turn the FrameStateFunctionInfo into a ZoneObject and avoid placement new
here?

I thought the recommendation is not to introduce any new ZoneObjects.

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/frame-stat...
File src/compiler/frame-states.cc (right):

https://codereview.chromium.org/1191243003/diff/60001/src/compiler/frame-stat...
src/compiler/frame-states.cc:32: lhs.state_combine() == rhs.state_combine();
On 2015/06/22 12:14:36, Benedikt Meurer wrote:
> I guess we also need lhs.info() == rhs.info() here.

Done.

[Jarin, 2015-06-23 07:13:52]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2015-06-23 07:13:52]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1191243003/#ps80001
(title: "Tweaks")

[commit-bot: I haz the power, 2015-06-23 07:14:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191243003/80001

[commit-bot: I haz the power, 2015-06-23 07:17:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-23 07:17:37]

Patchset 5 (id:??) landed as
https://crrev.com/de62b486e35c565639878b6e7d81e21bccac497c
Cr-Commit-Position: refs/heads/master@{#29214}