Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 1191243003: [turbofan] Factor out the function specific part from the frame state operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Tweaks Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-type-feedback.cc ('k') | test/cctest/compiler/test-js-typed-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-typed-lowering.cc
diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc
index 6b78973db54820c54d26636324da268e66a9ea12..f57d8c00279db70ec46a3108f3791ccaadbb2a76 100644
--- a/src/compiler/js-typed-lowering.cc
+++ b/src/compiler/js-typed-lowering.cc
@@ -252,8 +252,7 @@ class JSBinopReduction final {
}
Node* CreateFrameStateForLeftInput(Node* frame_state) {
- FrameStateCallInfo state_info =
- OpParameter<FrameStateCallInfo>(frame_state);
+ FrameStateInfo state_info = OpParameter<FrameStateInfo>(frame_state);
if (state_info.bailout_id() == BailoutId::None()) {
// Dummy frame state => just leave it as is.
@@ -270,8 +269,8 @@ class JSBinopReduction final {
// the stack top. This is the slot that full code uses to store the
// left operand.
const Operator* op = jsgraph()->common()->FrameState(
- state_info.type(), state_info.bailout_id(),
- OutputFrameStateCombine::PokeAt(1), state_info.shared_info());
+ state_info.bailout_id(), OutputFrameStateCombine::PokeAt(1),
+ state_info.function_info());
return graph()->NewNode(op,
frame_state->InputAt(kFrameStateParametersInput),
@@ -283,8 +282,7 @@ class JSBinopReduction final {
}
Node* CreateFrameStateForRightInput(Node* frame_state, Node* converted_left) {
- FrameStateCallInfo state_info =
- OpParameter<FrameStateCallInfo>(frame_state);
+ FrameStateInfo state_info = OpParameter<FrameStateInfo>(frame_state);
if (state_info.bailout_id() == BailoutId::None()) {
// Dummy frame state => just leave it as is.
@@ -294,8 +292,8 @@ class JSBinopReduction final {
// Create a frame state that stores the result of the operation to the
// top of the stack (i.e., the slot used for the right operand).
const Operator* op = jsgraph()->common()->FrameState(
- state_info.type(), state_info.bailout_id(),
- OutputFrameStateCombine::PokeAt(0), state_info.shared_info());
+ state_info.bailout_id(), OutputFrameStateCombine::PokeAt(0),
+ state_info.function_info());
// Change the left operand {converted_left} on the expression stack.
Node* stack = frame_state->InputAt(2);
« no previous file with comments | « src/compiler/js-type-feedback.cc ('k') | test/cctest/compiler/test-js-typed-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698