Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 1191193002: Hide canonicalPosition in VisiblePosition from header file (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisiblePosition.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index 046f5b6883f9c9c47e687b62db901d27e73890bd..6d5b4ab4690f062039d4262474898af445454412 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -58,6 +58,8 @@ VisiblePosition::VisiblePosition(const PositionWithAffinity& positionWithAffinit
init(positionWithAffinity.position(), positionWithAffinity.affinity());
}
+static Position canonicalPosition(const Position& passedPosition);
tkent 2015/06/19 03:53:58 Usually we don't add forward declaration for a sta
+
void VisiblePosition::init(const Position& position, EAffinity affinity)
{
m_affinity = affinity;
@@ -553,7 +555,7 @@ static Position canonicalizeCandidate(const Position& candidate)
return candidate;
}
-Position VisiblePosition::canonicalPosition(const Position& passedPosition)
+static Position canonicalPosition(const Position& passedPosition)
{
// Sometimes updating selection positions can be extremely expensive and occur
// frequently. Often calling preventDefault on mousedown events can avoid
« no previous file with comments | « Source/core/editing/VisiblePosition.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698