Hide canonicalPosition in VisiblePosition from header file

Source/core/editing/VisiblePosition.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Portions Copyright (c) 2011 Motorola Mobility, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 40 matching lines @@
 VisiblePosition::VisiblePosition(const Position &pos, EAffinity affinity)
 {
     init(pos, affinity);
 }
 
 VisiblePosition::VisiblePosition(const PositionWithAffinity& positionWithAffinity)
 {
     init(positionWithAffinity.position(), positionWithAffinity.affinity());
 }
 
+static Position canonicalPosition(const Position& passedPosition);

[tkent, 2015/06/19 03:53:58]

Usually we don't add forward declaration for a static function.  But the
function is too large to move here.
so, lgtm.

+
 void VisiblePosition::init(const Position& position, EAffinity affinity)
 {
     m_affinity = affinity;
 
     m_deepPosition = canonicalPosition(position);
 
     // When not at a line wrap, make sure to end up with DOWNSTREAM affinity.
     if (m_affinity == UPSTREAM && (isNull() || inSameLine(VisiblePosition(position, DOWNSTREAM), *this)))
         m_affinity = DOWNSTREAM;
 }
@@ skipping 475 matching lines @@
 {
     if (candidate.isNull())
         return Position();
     ASSERT(candidate.isCandidate());
     Position upstream = candidate.upstream();
     if (upstream.isCandidate())
         return upstream;
     return candidate;
 }
 
-Position VisiblePosition::canonicalPosition(const Position& passedPosition)
+static Position canonicalPosition(const Position& passedPosition)
 {
     // Sometimes updating selection positions can be extremely expensive and occur
     // frequently.  Often calling preventDefault on mousedown events can avoid
     // doing unnecessary text selection work.  http://crbug.com/472258.
     TRACE_EVENT0("blink", "VisiblePosition::canonicalPosition");
 
     // The updateLayout call below can do so much that even the position passed
     // in to us might get changed as a side effect. Specifically, there are code
     // paths that pass selection endpoints, and updateLayout can change the selection.
     Position position = passedPosition;
@@ skipping 225 matching lines @@
     else
         fprintf(stderr, "Cannot showTree for (nil) VisiblePosition.\n");
 }
 
 void showTree(const blink::VisiblePosition& vpos)
 {
     vpos.showTreeForThis();
 }
 
 #endif