Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1191113002: Remove separate SP enabled SKP run since it is now on by default (Closed)

Created:
5 years, 6 months ago by rmistry
Modified:
5 years, 6 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove separate SP enabled SKP run since it is now on by default Yesterday's RecreateSKPs_Canary run looks good: http://build.chromium.org/p/client.skia.fyi/builders/Housekeeper-Nightly-RecreateSKPs_Canary/builds/143 The generated SKPs look very reasonably sized: gs://chromium-skia-gm/playback_386/skps BUG=skia: NOTRY=true Committed: https://skia.googlesource.com/skia/+/4c58e085b27c4cd9813ed7cad2388194d1d1f089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M tools/skp/recreate_skps.py View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rmistry
5 years, 6 months ago (2015-06-18 14:26:53 UTC) #2
mtklein
lgtm Just was curious and tested out the v386 SKPs. They're ~50% bigger in total ...
5 years, 6 months ago (2015-06-18 14:45:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191113002/1
5 years, 6 months ago (2015-06-18 14:51:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/4c58e085b27c4cd9813ed7cad2388194d1d1f089
5 years, 6 months ago (2015-06-18 14:52:18 UTC) #8
rmistry
On 2015/06/18 14:52:18, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
5 years, 6 months ago (2015-06-18 14:53:44 UTC) #9
mtklein
5 years, 6 months ago (2015-06-18 15:09:11 UTC) #10
Message was sent while issue was closed.
On 2015/06/18 14:53:44, rmistry wrote:
> On 2015/06/18 14:52:18, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
https://skia.googlesource.com/skia/+/4c58e085b27c4cd9813ed7cad2388194d1d1f089
> 
> 
> The next set of buildbot SKPs (generated on Sunday) will all be SP enabled (if
> SP on by default is not reverted at that time).

sg

Powered by Google App Engine
This is Rietveld 408576698