Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: tools/skp/recreate_skps.py

Issue 1191113002: Remove separate SP enabled SKP run since it is now on by default (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/skp/recreate_skps.py
diff --git a/tools/skp/recreate_skps.py b/tools/skp/recreate_skps.py
index f32741a055c2276c9bd0e9c73aad7e7ec02062bb..a2c24df560b16a5e250a1bb6bb01535b9f5ef180 100644
--- a/tools/skp/recreate_skps.py
+++ b/tools/skp/recreate_skps.py
@@ -64,34 +64,6 @@ def main(chrome_src_path, browser_executable):
try:
shell_utils.run(webpages_playback_cmd)
-
- # Temporary change to enable Slimming Paint runs. See skia:3763.
- skia_page_sets_path = os.path.join(
- os.path.dirname(os.path.realpath(__file__)), 'page_sets')
- sp_skia_page_sets = [
- os.path.join(skia_page_sets_path, 'skia_carsvg_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_chalkboard_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_css3gradients_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_espn_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_gmailthread_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_googlehome_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_googlespreadsheet_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_jsfiddlebigcar_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_mapsvg_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_nytimes_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_samoasvg_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_tigersvg_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_ugamsolutions_desktop.py'),
- os.path.join(skia_page_sets_path, 'skia_digg_nexus10.py'),
- os.path.join(skia_page_sets_path, 'skia_gmail_nexus10.py'),
- os.path.join(skia_page_sets_path, 'skia_pravda_nexus10.py'),
- ]
- webpages_playback_cmd.extend([
- '--skp_prefix', 'sp_',
- '--browser_extra_args', '--enable-slimming-paint',
- '--page_sets', '%s' % ','.join(sp_skia_page_sets),
- ])
- shell_utils.run(webpages_playback_cmd)
finally:
# Clean up any leftover browser instances. This can happen if there are
# telemetry crashes, processes are not always cleaned up appropriately by
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698