Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5840)

Unified Diff: chrome/browser/extensions/extension_view.cc

Issue 119103: Part 1 of dragging extensions on the shelf. This part was just about getting... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_shelf.cc ('k') | chrome/browser/views/browser_bubble.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_view.cc
===================================================================
--- chrome/browser/extensions/extension_view.cc (revision 17478)
+++ chrome/browser/extensions/extension_view.cc (working copy)
@@ -42,13 +42,11 @@
void ExtensionView::DidChangeBounds(const gfx::Rect& previous,
const gfx::Rect& current) {
+ View::DidChangeBounds(previous, current);
// Propagate the new size to RenderWidgetHostView.
// We can't send size zero because RenderWidget DCHECKs that.
if (render_view_host()->view() && !current.IsEmpty())
render_view_host()->view()->SetSize(gfx::Size(width(), height()));
- // Layout is where the HWND is properly positioned.
- // TODO(erikkay) - perhaps this should be in NativeViewHost
- Layout();
}
void ExtensionView::ShowIfCompletelyLoaded() {
@@ -86,10 +84,9 @@
NativeViewHost::ViewHierarchyChanged(is_add, parent, child);
if (is_add && GetWidget() && !initialized_) {
initialized_ = true;
+ RenderWidgetHostView* view =
+ RenderWidgetHostView::CreateViewForWidget(render_view_host());
- RenderWidgetHostView* view = RenderWidgetHostView::CreateViewForWidget(
- render_view_host());
-
// TODO(mpcomplete): RWHV needs a cross-platform Init function.
#if defined(OS_WIN)
// Create the HWND. Note:
« no previous file with comments | « chrome/browser/extensions/extension_shelf.cc ('k') | chrome/browser/views/browser_bubble.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698