Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 119103: Part 1 of dragging extensions on the shelf. This part was just about getting... (Closed)

Created:
11 years, 6 months ago by Erik does not do reviews
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Part 1 of dragging extensions on the shelf. This part was just about getting the mechanics of the shelf handle and the dragging correct. Part 2 will actually allow the order to be changed.TEST=hover over an extension toolstrip, grab the handle and drag. release. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17559

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 14

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -43 lines) Patch
M chrome/browser/extensions/extension_shelf.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_shelf.cc View 1 2 13 chunks +140 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_view.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/views/browser_bubble.h View 4 chunks +18 lines, -4 lines 0 comments Download
M chrome/browser/views/browser_bubble.cc View 1 2 4 chunks +46 lines, -2 lines 0 comments Download
M chrome/browser/views/browser_bubble_win.cc View 1 1 chunk +11 lines, -16 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik does not do reviews
11 years, 6 months ago (2009-06-03 20:57:15 UTC) #1
sky
http://codereview.chromium.org/119103/diff/14/16 File chrome/browser/extensions/extension_shelf.cc (left): http://codereview.chromium.org/119103/diff/14/16#oldcode97 Line 97: AddChildView(title_); Now that you're no longer adding title_ ...
11 years, 6 months ago (2009-06-03 21:21:27 UTC) #2
Erik does not do reviews
new snapshot uploaded http://codereview.chromium.org/119103/diff/14/16 File chrome/browser/extensions/extension_shelf.cc (left): http://codereview.chromium.org/119103/diff/14/16#oldcode97 Line 97: AddChildView(title_); On 2009/06/03 21:21:27, sky ...
11 years, 6 months ago (2009-06-03 22:15:14 UTC) #3
sky
11 years, 6 months ago (2009-06-03 22:58:30 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698