runtime/vm/object.cc - Issue 1190973003: Fix crash with --noopt and no_snapshot: initialize megamorphic cache table before first code is run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 1190973003: Fix crash with --noopt and no_snapshot: initialize megamorphic cache table before first code is run. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 6a5830bacb4d19749267ccd873e81eed06b7e8a8..543ac2eb61eaab75560e6ca85c39c66ce98cba13 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -13356,6 +13356,7 @@ RawMegamorphicCache* MegamorphicCache::New() {

}

const intptr_t capacity = kInitialCapacity;

const Array& buckets = Array::Handle(Array::New(kEntryLength * capacity));

+ ASSERT(Isolate::Current()->megamorphic_cache_table()->miss_handler() != NULL);

const Function& handler = Function::Handle(

Isolate::Current()->megamorphic_cache_table()->miss_handler());

for (intptr_t i = 0; i < capacity; ++i) {

« no previous file with comments | « runtime/vm/dart.cc ('k') | no next file » | no next file with comments »