runtime/vm/dart.cc - Issue 1190973003: Fix crash with --noopt and no_snapshot: initialize megamorphic cache table before first code is run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart.cc

Issue 1190973003: Fix crash with --noopt and no_snapshot: initialize megamorphic cache table before first code is run. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart.cc

diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc

index 4d39b00acd22675aa26b1ad87826b9e0c66eab05..6579aaf853665d379332d262c7732a4e36fa7b05 100644

--- a/runtime/vm/dart.cc

+++ b/runtime/vm/dart.cc

@@ -299,12 +299,12 @@ RawError* Dart::InitializeIsolate(const uint8_t* snapshot_buffer, void* data) {

Object::VerifyBuiltinVtables();

StubCode::Init(isolate);

+ isolate->megamorphic_cache_table()->InitMissHandler();

if (snapshot_buffer == NULL) {

if (!isolate->object_store()->PreallocateObjects()) {

return isolate->object_store()->sticky_error();

}

- isolate->megamorphic_cache_table()->InitMissHandler();

isolate->heap()->EnableGrowthControl();

isolate->set_init_callback_data(data);

« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »