Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1190813002: Make GN build match gyp (/bigobj everywhere) and remove now-unnecessary settings (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
Reviewers:
brettw, jam, brucedawson
CC:
chromium-reviews, darin-cc_chromium.org, jam, brucedawson, jschuh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GN build match gyp (/bigobj everywhere) and remove now-unnecessary settings Previously added to gyp by https://codereview.chromium.org/1188603004. R=brettw@chromium.org,jam@chromium.org BUG=173851 Committed: https://crrev.com/c4d566d2e08b7ec74bba484676a9b408d3866c42 Cr-Commit-Position: refs/heads/master@{#334734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -27 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M content/content.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M content/content_shell_and_tests.gyp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
scottmg
brettw for compiler build.gn jam for content owners
5 years, 6 months ago (2015-06-16 18:35:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190813002/1
5 years, 6 months ago (2015-06-16 19:06:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-16 20:14:21 UTC) #6
brucedawson
lgtm
5 years, 6 months ago (2015-06-16 20:20:19 UTC) #8
jam
lgtm
5 years, 6 months ago (2015-06-16 22:54:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190813002/1
5 years, 6 months ago (2015-06-16 22:59:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 23:06:51 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4d566d2e08b7ec74bba484676a9b408d3866c42 Cr-Commit-Position: refs/heads/master@{#334734}
5 years, 6 months ago (2015-06-16 23:07:42 UTC) #13
Marijn Kruisselbrink
5 years, 6 months ago (2015-06-16 23:41:01 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1177073007/ by mek@chromium.org.

The reason for reverting is:
C:\b\build\slave\Win_x64_Builder__dbg_\build\src\content\common\content_message_generator.cc
: fatalerror C1128: number of sections exceeded object file format limit :
compile with /bigobj

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28db....

Powered by Google App Engine
This is Rietveld 408576698