Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1188603004: win: Add /bigobj globally (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
Reviewers:
jschuh, brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Add /bigobj globally This flag has been sprinkled in various places, but really should just be on by default (it causes incompatibility with ancient linkers, but we haven't cared about that for years.) Previously there was some problems with libvpx (parsing .obj files) in bug 173851, but these are believed to be fixed now, so turn it on globally. If this sticks, I'll remove the other instances that are sprinkled about. R=jschuh@chromium.org,brucedawson@chromium.org BUG=500674, 173851 Committed: https://crrev.com/b05c228f0b143178c29599ae311b02d6f53b1de5 Cr-Commit-Position: refs/heads/master@{#334501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/common.gypi View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 6 months ago (2015-06-15 22:49:13 UTC) #1
brucedawson
lgtm
5 years, 6 months ago (2015-06-15 22:51:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188603004/1
5 years, 6 months ago (2015-06-15 22:54:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 00:06:03 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 00:07:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b05c228f0b143178c29599ae311b02d6f53b1de5
Cr-Commit-Position: refs/heads/master@{#334501}

Powered by Google App Engine
This is Rietveld 408576698