Make Mac menu code obey incognito availability.

chrome/browser/ui/browser_command_controller_base.h

Index: chrome/browser/ui/browser_command_controller_base.h
diff --git a/chrome/browser/ui/browser_command_controller_base.h b/chrome/browser/ui/browser_command_controller_base.h
new file mode 100644
index 0000000000000000000000000000000000000000..72761582f614810e0ff13e305c66d357f72cd7cb
--- /dev/null
+++ b/chrome/browser/ui/browser_command_controller_base.h
@@ -0,0 +1,26 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_BASE_H_
+#define CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_BASE_H_
+
+class CommandUpdater;
+class Profile;
+
+namespace chrome {
+
+class BrowserCommandControllerBase {

[Robert Sesek, 2013/01/15 22:27:18]

Why split this up? And it's not really a Base class.

[Avi (use Gerrit), 2013/01/15 22:35:06]

I need to split this because AppController(Mac) needs to have the same logic for
enabling/disabling commands as the BrowserCommandController. So I factored out
that logic.

It is a "Base" class conceptually in that both AppController(Mac) and
BrowserCommandController use it. If you have a different name suggestion I'd be
happy to use it.

[Robert Sesek, 2013/01/15 22:44:37]

Why can't they just be static on the main BrowserCommandController?

[Avi (use Gerrit), 2013/01/15 22:49:30]

It felt awkward to have two random things that AppController poked
BrowserCommandController for. I guess this is just as awkward. I'll switch it
back.

+ public:
+  // Update commands whose state depends on incognito mode availability.
+  static void UpdateCommandsForIncognitoAvailability(
+      CommandUpdater* command_updater,
+      Profile* profile);
+
+  // Updates the open-file state (Mac Only).
+  static void UpdateOpenFileState(CommandUpdater* command_updater);
+};
+
+}  // namespace chrome
+
+#endif  // CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_BASE_H_