chrome/browser/ui/browser_command_controller_base.h - Issue 11906008: Make Mac menu code obey incognito availability.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/browser_command_controller_base.h

Issue 11906008: Make Mac menu code obey incognito availability. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test fix Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/browser_command_controller.cc ('K') | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/browser_command_controller_base.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_BASE_H_

	6 #define CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_BASE_H_

	7

	8 class CommandUpdater;

	9 class Profile;

	10

	11 namespace chrome {

	12

	13 class BrowserCommandControllerBase {
	Robert Sesek 2013/01/15 22:27:18 Why split this up? And it's not really a Base clas Why split this up? And it's not really a Base class. Avi (use Gerrit) 2013/01/15 22:35:06 I need to split this because AppController(Mac) ne Show quoted text On 2013/01/15 22:27:18, rsesek wrote: > Why split this up? And it's not really a Base class. I need to split this because AppController(Mac) needs to have the same logic for enabling/disabling commands as the BrowserCommandController. So I factored out that logic. It is a "Base" class conceptually in that both AppController(Mac) and BrowserCommandController use it. If you have a different name suggestion I'd be happy to use it. Robert Sesek 2013/01/15 22:44:37 Why can't they just be static on the main BrowserC Show quoted text On 2013/01/15 22:35:06, Avi wrote: > On 2013/01/15 22:27:18, rsesek wrote: > > Why split this up? And it's not really a Base class. > > I need to split this because AppController(Mac) needs to have the same logic for > enabling/disabling commands as the BrowserCommandController. So I factored out > that logic. > > It is a "Base" class conceptually in that both AppController(Mac) and > BrowserCommandController use it. If you have a different name suggestion I'd be > happy to use it. Why can't they just be static on the main BrowserCommandController? Avi (use Gerrit) 2013/01/15 22:49:30 It felt awkward to have two random things that App It felt awkward to have two random things that AppController poked BrowserCommandController for. I guess this is just as awkward. I'll switch it back.
	14 public:

	15 // Update commands whose state depends on incognito mode availability.

	16 static void UpdateCommandsForIncognitoAvailability(

	17 CommandUpdater* command_updater,

	18 Profile* profile);

	19

	20 // Updates the open-file state (Mac Only).

	21 static void UpdateOpenFileState(CommandUpdater* command_updater);

	22 };

	23

	24 } // namespace chrome

	25

	26 #endif // CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_BASE_H_

OLD	NEW