Issue 1190223002: Make the skyanalyzer check the stocks app during testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1190223002: Make the skyanalyzer check the stocks app during testing. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make the skyanalyzer check the stocks app during testing. Also, fix the last warning which I conveniently (yet accidentally) left in to test this. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5f6e28702670060913631c1bd8bdda863578f73b

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -3 lines)			Patch
M	sky/sdk/lib/rendering/box.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/tools/webkitpy/layout_tests/port/base.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/tools/webkitpy/layout_tests/run_webkit_tests.py	View	5 chunks	+28 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1190223002/diff/1/sky/tools/webkitpy/layout_tests/run_webkit_tests.py File sky/tools/webkitpy/layout_tests/run_webkit_tests.py (right): https://codereview.chromium.org/1190223002/diff/1/sky/tools/webkitpy/layout_tests/run_webkit_tests.py#newcode399 sky/tools/webkitpy/layout_tests/run_webkit_tests.py:399: mojo_dir = os.path.dirname(os.path.dirname(build_dir)) s/mojo_dir/src_dir/ We should really just ...

5 years, 6 months ago (2015-06-19 00:12:28 UTC) #2

Hixie

5 years, 6 months ago (2015-06-19 00:17:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5f6e28702670060913631c1bd8bdda863578f73b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages