Make the skyanalyzer check the stocks app during testing.

sky/tools/webkitpy/layout_tests/run_webkit_tests.py

 # Copyright (C) 2010 Google Inc. All rights reserved.
 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Szeged
 # Copyright (C) 2011 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 13 matching lines @@
 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import logging
 import optparse
 import os
+import subprocess
 import sys
 import traceback
 
 from webkitpy.common.host import Host
 from webkitpy.layout_tests.controllers.manager import Manager
 from webkitpy.layout_tests.models import test_run_results
 from webkitpy.layout_tests.port import configuration_options, platform_options
 from webkitpy.layout_tests.views import buildbot_results
 from webkitpy.layout_tests.views import printing
 from webkitpy.layout_tests.generate_results_dashboard import GenerateDashBoard
@@ skipping 19 matching lines @@
         return run_checks(host, options, stderr)
 
     try:
         port = host.port_factory.get(options.platform, options)
     except NotImplementedError, e:
         # FIXME: is this the best way to handle unsupported port names?
         print >> stderr, str(e)
         return test_run_results.UNEXPECTED_ERROR_EXIT_STATUS
 
     try:
-        run_details = run(port, options, args, stderr)
+        run_details = run_tests(port, options, args, stderr)
         if ((run_details.exit_code not in test_run_results.ERROR_CODES or
              run_details.exit_code == test_run_results.EARLY_EXIT_STATUS) and
             not run_details.initial_results.keyboard_interrupted):
             bot_printer = buildbot_results.BuildBotPrinter(stdout, options.debug_rwt_logging)
             bot_printer.print_results(run_details)
 
         if options.enable_versioned_results:
             gen_dash_board = GenerateDashBoard(port)
             gen_dash_board.generate()
 
-        return run_details.exit_code
+        if run_details.exit_code != 0:
+            return run_details.exit_code
+
+        analyzer_result = run_analyzer(port, options, args, stderr)
+        return analyzer_result
 
     # We need to still handle KeyboardInterrupt, atleast for webkitpy unittest cases.
     except KeyboardInterrupt:
         return test_run_results.INTERRUPTED_EXIT_STATUS
     except test_run_results.TestRunException as e:
         print >> stderr, e.msg
         return e.code
     except BaseException as e:
         if isinstance(e, Exception):
             print >> stderr, '\n%s raised: %s' % (e.__class__.__name__, str(e))
@@ skipping 267 matching lines @@
 
         if not options.test_list:
             options.test_list = []
         options.test_list.append(port.host.filesystem.join(port.layout_tests_dir(), 'SmokeTests'))
         if not options.skipped:
             options.skipped = 'always'
 
     if not options.skipped:
         options.skipped = 'default'
 
-def run(port, options, args, logging_stream):
+def run_tests(port, options, args, logging_stream):
     logger = logging.getLogger()
     logger.setLevel(logging.DEBUG if options.debug_rwt_logging else logging.INFO)
 
     try:
         printer = printing.Printer(port, options, logging_stream, logger=logger)
 
         _set_up_derived_options(port, options, args)
         manager = Manager(port, options, printer)
         printer.print_config(port.results_directory())
 
         run_details = manager.run(args)
         _log.debug("Testing completed, Exit status: %d" % run_details.exit_code)
         return run_details
     finally:
         printer.cleanup()
 
+def run_analyzer(port, options, args, logging_stream):
+    build_dir = port.analyzer_build_directory()
+    test_dir = os.path.dirname(os.path.abspath(__file__))
+    tools_dir = os.path.dirname(os.path.dirname(test_dir))
+    analyzer_path = os.path.join(tools_dir, 'skyanalyzer')
+    mojo_dir = os.path.dirname(os.path.dirname(build_dir))

[abarth-chromium, 2015/06/19 00:12:28]

s/mojo_dir/src_dir/

We should really just compute this from the tools_dir.

+    analyzer_target_path = os.path.join(mojo_dir, 'sky/examples/stocks2/lib/stock_app.dart')
+    analyzer_args = [
+        analyzer_path,
+        build_dir,
+        analyzer_target_path
+    ]
+    try:
+        output = subprocess.check_output(analyzer_args, stderr=subprocess.STDOUT)
+    except subprocess.CalledProcessError as e:
+        print >> logging_stream, "Analyzer found new issues:"
+        print >> logging_stream, e.output
+        return e.returncode
+    return 0
+
 if __name__ == '__main__':
     sys.exit(main(sys.argv[1:], sys.stdout, sys.stderr))