Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1190153002: Make mapLocalToContainer() work properly for content that follows a column spanner. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
blink-reviews, szager+layoutwatch_chromium.org, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, mstensho (USE GERRIT)
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Make mapLocalToContainer() work properly for content that follows a column spanner. mapLocalToContainer() uses offsetFromContainer(), which uses columnOffset() (which calls flowThreadTranslationAtOffset()), which didn't always return the correct translation relatively to the flow thread. This also improves the fix for bug 479155. MultiColumnFragmentainerGroup::flowThreadTranslationAtOffset() needs to return a translation relative to the flow thread, and the code we had basically just happened to work by accident (flipping a flow thread portion rectangle for writing mode around a column set is just bogus, since a column set isn't sized in the flow thread coordinate space). This solution would cause problems with the upcoming fix for bug 499706, because then the last column may be shorter than the others (because it's not completely filled). BUG=501772 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197373

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 6 months ago (2015-06-18 13:54:47 UTC) #1
dsinclair
lgtm
5 years, 6 months ago (2015-06-18 16:55:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190153002/1
5 years, 6 months ago (2015-06-18 16:56:23 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 17:04:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197373

Powered by Google App Engine
This is Rietveld 408576698