Source/core/layout/LayoutMultiColumnSet.cpp - Issue 1190153002: Make mapLocalToContainer() work properly for content that follows a column spanner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutMultiColumnSet.cpp

Issue 1190153002: Make mapLocalToContainer() work properly for content that follows a column spanner. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/vertical-rl/client-rect-after-spanner-expected.txt ('k') | Source/core/layout/MultiColumnFragmentainerGroup.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutMultiColumnSet.cpp

diff --git a/Source/core/layout/LayoutMultiColumnSet.cpp b/Source/core/layout/LayoutMultiColumnSet.cpp

index d998044acaf250f089877ab13c1bce6bfe070609..3882ab3f80e1d47d2d76c1a16c0c5e5de89521d0 100644

--- a/Source/core/layout/LayoutMultiColumnSet.cpp

+++ b/Source/core/layout/LayoutMultiColumnSet.cpp

@@ -160,8 +160,7 @@ bool LayoutMultiColumnSet::heightIsAuto() const

LayoutSize LayoutMultiColumnSet::flowThreadTranslationAtOffset(LayoutUnit blockOffset) const

{

- const MultiColumnFragmentainerGroup& row = fragmentainerGroupAtFlowThreadOffset(blockOffset);

- return row.offsetFromColumnSet() + row.flowThreadTranslationAtOffset(blockOffset);

+ return fragmentainerGroupAtFlowThreadOffset(blockOffset).flowThreadTranslationAtOffset(blockOffset);

}

LayoutPoint LayoutMultiColumnSet::visualPointToFlowThreadPoint(const LayoutPoint& visualPoint) const