Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: sky/engine/core/painting/PaintingContext.cpp

Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co… (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rebased version of previous patch Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/painting/PaintingContext.cpp
diff --git a/sky/engine/core/painting/PaintingContext.cpp b/sky/engine/core/painting/PaintingContext.cpp
index 1ab9198e5dca7eb9f0cd9a176c947ea8c9ea0132..96fab9038c824e411e032611d29a68416b303a38 100644
--- a/sky/engine/core/painting/PaintingContext.cpp
+++ b/sky/engine/core/painting/PaintingContext.cpp
@@ -17,8 +17,11 @@ PassRefPtr<PaintingContext> PaintingContext::create(PassRefPtr<Element> element,
return adoptRef(new PaintingContext(element, size));
}
+// TODO(iansf): Get rid of PaintingContext, which is only relevant to DOM-based
+// Sky apps, which are now deprecated. For now, make the compiler
+// happy by constructing Canvas with a nullptr.
PaintingContext::PaintingContext(PassRefPtr<Element> element, const FloatSize& size)
- : Canvas(size)
+ : Canvas(nullptr)
, m_element(element)
{
}
@@ -29,9 +32,6 @@ PaintingContext::~PaintingContext()
void PaintingContext::commit()
{
- if (!isRecording())
- return;
- PaintingTasks::enqueueCommit(m_element, finishRecording());
m_element->document().scheduleVisualUpdate();
}

Powered by Google App Engine
This is Rietveld 408576698