chrome/test/android/javatests_staging/src/org/chromium/chrome/test/ChromeTabbedActivityTestBase.java - Issue 1190103002: Make lint fail builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/android/javatests_staging/src/org/chromium/chrome/test/ChromeTabbedActivityTestBase.java

Issue 1190103002: Make lint fail builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set android_webview to use minsdk 19 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java ('K') | « chrome/test/android/javatests_staging/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java ('k') | chrome/test/android/javatests_staging/src/org/chromium/chrome/test/util/OmniboxTestUtils.java » ('j') | components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/android/javatests_staging/src/org/chromium/chrome/test/ChromeTabbedActivityTestBase.java

diff --git a/chrome/test/android/javatests_staging/src/org/chromium/chrome/test/ChromeTabbedActivityTestBase.java b/chrome/test/android/javatests_staging/src/org/chromium/chrome/test/ChromeTabbedActivityTestBase.java

index 7e2b46c6576500bebedea984d67065a642c11203..b1ed6ecea8a05d59e3e65b95566bb560f04e8003 100644

--- a/chrome/test/android/javatests_staging/src/org/chromium/chrome/test/ChromeTabbedActivityTestBase.java

+++ b/chrome/test/android/javatests_staging/src/org/chromium/chrome/test/ChromeTabbedActivityTestBase.java

@@ -24,6 +24,7 @@ import org.chromium.chrome.browser.tabmodel.TabModelUtils;

import org.chromium.content.browser.test.util.CallbackHelper;

import org.chromium.content.browser.test.util.TestTouchUtils;

+import java.util.Locale;

import java.util.concurrent.TimeoutException;

/**

@@ -84,7 +85,8 @@ public abstract class ChromeTabbedActivityTestBase extends

try {

pageLoadedCallbacks[i].waitForCallback(0);

} catch (TimeoutException e) {

- fail(String.format("PAGE_LOAD_FINISHED was not received for tabId=%d", tabIds[i]));

+ fail(String.format(Locale.US, "PAGE_LOAD_FINISHED was not received for tabId=%d",

+ tabIds[i]));

}