components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java - Issue 1190103002: Make lint fail builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

Issue 1190103002: Make lint fail builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set android_webview to use minsdk 19 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java ('K') | « chrome/test/android/unit_tests_apk/AndroidManifest.xml ('k') | components/test/android/browsertests_apk/AndroidManifest.xml.jinja2 » ('j') | remoting/android/java/AndroidManifest.xml.jinja2 » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

diff --git a/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java b/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

index 282b8414df14ff80d5fd3730dd50d57f657dd89c..423abd0c61d0d73d31da43373e36be0f07c6684f 100644

--- a/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

+++ b/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

@@ -4,6 +4,7 @@

package org.chromium.net;

+import android.annotation.SuppressLint;

import android.app.Activity;

import android.net.Uri;

import android.os.AsyncTask;

@@ -211,6 +212,7 @@ public class CronetPerfTestActivity extends Activity {

}

+ @SuppressLint("NewApi")

newt (away) 2015/06/18 20:26:59 mention bug to fix this suppression

aurimas (slooooooooow) 2015/06/18 21:37:54 Done

private void startLogging() {

if (getConfigBoolean("CAPTURE_NETLOG")) {

mCronetContext.startNetLogToFile(getFilesDir().getPath() + "/" + mName + ".json",