Chromium Code Reviews Chromium Code Reviews
Issue 1190103002:
Make lint fail builds. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: build/android/lint/suppressions.xml |
| diff --git a/build/android/lint/suppressions.xml b/build/android/lint/suppressions.xml |
| index 24b084687f90b3bdda0d49f17758efe4495e4aed..b2e83a9fc2a742075525bb38c0bb666132588b5a 100644 |
| --- a/build/android/lint/suppressions.xml |
| +++ b/build/android/lint/suppressions.xml |
| @@ -57,6 +57,8 @@ Still reading? |
| <issue id="IconLocation"> |
| <ignore path="content/shell/android/java/res/"/> |
| <ignore path="chrome/android/shell/res/"/> |
| + <ignore path="res/drawable/icon.png"/> |
|
newt (away)
2015/06/18 20:26:59
add comment explaining the full path
aurimas (slooooooooow)
2015/06/18 21:37:54
Done
|
| + <ignore path="remoting/android/java/res"/> |
| </issue> |
| <issue id="InconsistentLayout" severity="ignore"/> |
| <issue id="InflateParams" severity="ignore"/> |
| @@ -78,6 +80,7 @@ Still reading? |
| <ignore path="AndroidManifest.xml"/> |
| </issue> |
| <issue id="Overdraw" severity="ignore"/> |
| + <issue id="ProtectedPermissions" severity="ignore"/> |
|
newt (away)
2015/06/18 20:26:59
file a bug about removing inject events permission
aurimas (slooooooooow)
2015/06/18 21:37:54
Done
|
| <issue id="Recycle" severity="ignore"/> |
| <issue id="Registered" severity="ignore"/> |
| <issue id="RtlCompat" severity="ignore"/> |
| @@ -93,6 +96,8 @@ Still reading? |
| targets have been merged. crbug.com/484934 |
| --> |
| <ignore path="chrome/android/java/res" /> |
| + <ignore path="content/shell/android/shell_apk/res/layout/content_shell_activity.xml" /> |
| + <ignore path="content/shell/android/shell_apk/res/values/strings.xml" /> |
| </issue> |
| <issue id="SignatureOrSystemPermissions" severity="ignore"/> |
| <issue id="UnusedAttribute" severity="ignore"/> |
