Pass MotionEvent tool type to Blink.

Pass MotionEvent tool type to Blink.

This maps MotionEvent tool type to PointerEvent pointerType and passes
that to WebTouchPoints.

This CL is a part of a patch series:
 1. https://codereview.chromium.org/1253183005/
    for new WebPointerProperties fields
 2. https://codereview.chromium.org/1260693003/
    for eventSender web pointer property support
 3. https://codereview.chromium.org/1192463008/
    for handling pointer type in Blink event handlers
 4. https://codereview.chromium.org/1190013002/ (this)

BUG=514360
Committed: https://crrev.com/3c4c729b54ab44ef38c2b3bddeb19dc5e2c0de7e
Cr-Commit-Position: refs/heads/master@{#342992}

[USE eero AT chromium.org, 2015-06-17 14:03:52]

e.hakkinen@samsung.com changed reviewers:
+ mustaq@chromium.org, rbyers@chromium.org, sadrul@chromium.org

[USE eero AT chromium.org, 2015-06-17 14:03:52]

PTAL

[USE eero AT chromium.org, 2015-07-31 14:53:13]

e.hakkinen@samsung.com changed reviewers:
- mustaq@chromium.org, rbyers@chromium.org

[USE eero AT chromium.org, 2015-07-31 18:01:03]

e.hakkinen@samsung.com changed reviewers:
+ jdduke@chromium.org

[USE eero AT chromium.org, 2015-08-07 17:35:12]

PTAL. Blink side CLs landed (and have finally rolled into DEPS).

[jdduke (slow), 2015-08-07 18:06:34]

https://codereview.chromium.org/1190013002/diff/40001/ui/events/blink/blink_e...
File ui/events/blink/blink_event_util.cc (right):

https://codereview.chromium.org/1190013002/diff/40001/ui/events/blink/blink_e...
ui/events/blink/blink_event_util.cc:76: switch (event.GetToolType()) {
Don't we need a pointer_index here?

[USE eero AT chromium.org, 2015-08-10 12:28:58]

https://codereview.chromium.org/1190013002/diff/40001/ui/events/blink/blink_e...
File ui/events/blink/blink_event_util.cc (right):

https://codereview.chromium.org/1190013002/diff/40001/ui/events/blink/blink_e...
ui/events/blink/blink_event_util.cc:76: switch (event.GetToolType()) {
On 2015/08/07 18:06:34, jdduke wrote:
> Don't we need a pointer_index here?

Yes, we do, of course.

[jdduke (slow), 2015-08-10 20:54:59]

lgtm. It'd be nice if we had some test coverage here but it appears we lack that
for both of these conversion routines already, so I won't ask you to add them.

[jdduke (slow), 2015-08-10 20:55:41]

Sigh, I guess a test might have caught this?

https://codereview.chromium.org/1190013002/diff/60001/ui/events/blink/blink_e...
File ui/events/blink/blink_event_util.cc (right):

https://codereview.chromium.org/1190013002/diff/60001/ui/events/blink/blink_e...
ui/events/blink/blink_event_util.cc:76: switch (event.GetToolType()) {
Wait, why aren't you calling event.GetToolType(pointer_index)?

[USE eero AT chromium.org, 2015-08-10 22:43:37]

https://codereview.chromium.org/1190013002/diff/60001/ui/events/blink/blink_e...
File ui/events/blink/blink_event_util.cc (right):

https://codereview.chromium.org/1190013002/diff/60001/ui/events/blink/blink_e...
ui/events/blink/blink_event_util.cc:76: switch (event.GetToolType()) {
On 2015/08/10 20:55:41, jdduke wrote:
> Wait, why aren't you calling event.GetToolType(pointer_index)?

Embarrassing. I will fix that tomorrow.

[USE eero AT chromium.org, 2015-08-11 14:37:08]

https://codereview.chromium.org/1190013002/diff/60001/ui/events/blink/blink_e...
File ui/events/blink/blink_event_util.cc (right):

https://codereview.chromium.org/1190013002/diff/60001/ui/events/blink/blink_e...
ui/events/blink/blink_event_util.cc:76: switch (event.GetToolType()) {
On 2015/08/10 22:43:37, e_hakkinen wrote:
> On 2015/08/10 20:55:41, jdduke wrote:
> > Wait, why aren't you calling event.GetToolType(pointer_index)?
> 
> Embarrassing. I will fix that tomorrow.

Done. Thanks for spotting that and sorry for my mistake.

[jdduke (slow), 2015-08-11 14:57:38]

On 2015/08/11 14:37:08, e_hakkinen wrote:
>
https://codereview.chromium.org/1190013002/diff/60001/ui/events/blink/blink_e...
> File ui/events/blink/blink_event_util.cc (right):
> 
>
https://codereview.chromium.org/1190013002/diff/60001/ui/events/blink/blink_e...
> ui/events/blink/blink_event_util.cc:76: switch (event.GetToolType()) {
> On 2015/08/10 22:43:37, e_hakkinen wrote:
> > On 2015/08/10 20:55:41, jdduke wrote:
> > > Wait, why aren't you calling event.GetToolType(pointer_index)?
> > 
> > Embarrassing. I will fix that tomorrow.
> 
> Done. Thanks for spotting that and sorry for my mistake.

Sure, lgtm.

[USE eero AT chromium.org, 2015-08-11 15:19:52]

The CQ bit was checked by e.hakkinen@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 15:20:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190013002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1190013002/80001

[USE eero AT chromium.org, 2015-08-11 15:40:04]

@sadrul: I think that I need your approval for
ui/events/blink/blink_event_util.cc.

[commit-bot: I haz the power, 2015-08-11 17:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 17:33:16]

Dry run: This issue passed the CQ dry run.

[sadrul, 2015-08-11 19:33:35]

lgtm

https://codereview.chromium.org/1190013002/diff/80001/ui/events/blink/blink_e...
File ui/events/blink/blink_event_util.cc (right):

https://codereview.chromium.org/1190013002/diff/80001/ui/events/blink/blink_e...
ui/events/blink/blink_event_util.cc:88: NOTREACHED();
NOTREACHED() << "Invalid MotionEvent::ToolType = " <<
event.GetToolType(pointer_index);

[USE eero AT chromium.org, 2015-08-12 07:50:11]

https://codereview.chromium.org/1190013002/diff/80001/ui/events/blink/blink_e...
File ui/events/blink/blink_event_util.cc (right):

https://codereview.chromium.org/1190013002/diff/80001/ui/events/blink/blink_e...
ui/events/blink/blink_event_util.cc:88: NOTREACHED();
On 2015/08/11 19:33:34, sadrul wrote:
> NOTREACHED() << "Invalid MotionEvent::ToolType = " <<
> event.GetToolType(pointer_index);

Done.

[USE eero AT chromium.org, 2015-08-12 07:50:15]

The CQ bit was checked by e.hakkinen@samsung.com

[USE eero AT chromium.org, 2015-08-12 07:50:16]

The patchset sent to the CQ was uploaded after l-g-t-m from jdduke@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1190013002/#ps100001
(title: "NOTREACHED message")

[commit-bot: I haz the power, 2015-08-12 07:50:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190013002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1190013002/100001

[commit-bot: I haz the power, 2015-08-12 08:46:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-08-12 08:47:43]

Patchset 6 (id:??) landed as
https://crrev.com/3c4c729b54ab44ef38c2b3bddeb19dc5e2c0de7e
Cr-Commit-Position: refs/heads/master@{#342992}