Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 1189963002: [turbofan] Remove ineffective optimization from ControlReducer. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove ineffective optimization from ControlReducer. This optimization just duplicates part of the ToBoolean rule in the Typer, and it doesn't make sense to have adhoc partial typing rules in the ControlReducer anyway. R=jarin@chromium.org Committed: https://crrev.com/ad6e7391653d3cd7a899634948ec7cebead2600c Cr-Commit-Position: refs/heads/master@{#29064}

Patch Set 1 #

Patch Set 2 : Remove bogus tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -51 lines) Patch
M src/compiler/control-reducer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/unittests/compiler/control-reducer-unittest.cc View 1 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-17 05:20:35 UTC) #1
Benedikt Meurer
Hey Jaro, Removing dead code. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-17 05:21:30 UTC) #2
Jarin
lgtm (once you fix/remove the test).
5 years, 6 months ago (2015-06-17 05:35:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189963002/20001
5 years, 6 months ago (2015-06-17 05:42:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-17 06:11:45 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 06:12:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad6e7391653d3cd7a899634948ec7cebead2600c
Cr-Commit-Position: refs/heads/master@{#29064}

Powered by Google App Engine
This is Rietveld 408576698