Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: src/compiler/control-reducer.cc

Issue 1189963002: [turbofan] Remove ineffective optimization from ControlReducer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove bogus tests. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/unittests/compiler/control-reducer-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/control-reducer.cc
diff --git a/src/compiler/control-reducer.cc b/src/compiler/control-reducer.cc
index ef2e7f68be16da0cba7f5a66d94eb8b4c1f18d3d..05cf5ec897df208bce81061a60ace99150a16c0c 100644
--- a/src/compiler/control-reducer.cc
+++ b/src/compiler/control-reducer.cc
@@ -212,11 +212,6 @@ class ControlReducerImpl final : public AdvancedReducer {
default:
break;
}
- if (NodeProperties::IsTyped(cond)) {
- // If the node has a range type, check whether the range excludes 0.
- Type* type = NodeProperties::GetBounds(cond).upper;
- if (type->IsRange() && (type->Min() > 0 || type->Max() < 0)) return kTrue;
- }
return kUnknown;
}
« no previous file with comments | « no previous file | test/unittests/compiler/control-reducer-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698