Source/core/html/HTMLElement.idl - Issue 1189663004: Move Element.dataset to HTMLElement.dataset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLElement.idl

Issue 1189663004: Move Element.dataset to HTMLElement.dataset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Uploading same patch as PS1 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLElement.idl

diff --git a/Source/core/html/HTMLElement.idl b/Source/core/html/HTMLElement.idl

index ba4e21e010cf60174a9b573a5130f506d2002633..7a849e9443fef9fa96094778f023998820335f0a 100644

--- a/Source/core/html/HTMLElement.idl

+++ b/Source/core/html/HTMLElement.idl

@@ -26,7 +26,7 @@ interface HTMLElement : Element {

[Reflect] attribute DOMString lang;

attribute boolean translate;

attribute DOMString dir;

- // FIXME: dataset is on Element. crbug.com/498485

+ [SameObject, PerWorldBindings] readonly attribute DOMStringMap dataset;

// user interaction

[Reflect] attribute boolean hidden;

« no previous file with comments | « Source/core/dom/Element.idl ('k') | no next file » | no next file with comments »