Source/core/dom/Element.idl - Issue 1189663004: Move Element.dataset to HTMLElement.dataset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.idl

Issue 1189663004: Move Element.dataset to HTMLElement.dataset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Uploading same patch as PS1 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.idl

diff --git a/Source/core/dom/Element.idl b/Source/core/dom/Element.idl

index e38862e729d74fe741b7e3ec57e95addfa1c02c4..e7ae5eba6e31fd5299a056d7a1e5bb2d7fdba75f 100644

--- a/Source/core/dom/Element.idl

+++ b/Source/core/dom/Element.idl

@@ -103,11 +103,6 @@

[MeasureAs=ElementOffsetWidth] readonly attribute long offsetWidth;

[MeasureAs=ElementOffsetHeight] readonly attribute long offsetHeight;

- // HTML

- // https://html.spec.whatwg.org/#htmlelement

- // FIXME: dataset should be on HTMLElement. crbug.com/498485

- [SameObject, PerWorldBindings] readonly attribute DOMStringMap dataset;

// Non-standard APIs

// https://www.w3.org/Bugs/Public/show_bug.cgi?id=19962

[RaisesException, CustomElementCallbacks, MeasureAs=InsertAdjacentElement] Element insertAdjacentElement(DOMString where, Element element);