Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1189643002: Avoid using computed property literals in TypedArrays code (Closed)

Created:
5 years, 6 months ago by Dan Ehrenberg
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid using computed property literals in TypedArrays code Computed property literals don't seem to work in nosnap yet, leading to a syntax error. R=adamk,arv Committed: https://crrev.com/e1efb4be112c0d6d095628af125c2eb7ae7fcd99 Cr-Commit-Position: refs/heads/master@{#29032}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/typedarray.js View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
Dan Ehrenberg
5 years, 6 months ago (2015-06-15 20:26:46 UTC) #1
adamk
lgtm
5 years, 6 months ago (2015-06-15 20:28:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189643002/1
5 years, 6 months ago (2015-06-15 20:28:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 21:11:10 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e1efb4be112c0d6d095628af125c2eb7ae7fcd99 Cr-Commit-Position: refs/heads/master@{#29032}
5 years, 6 months ago (2015-06-15 21:11:24 UTC) #6
arv (Not doing code reviews)
5 years, 6 months ago (2015-06-16 16:41:05 UTC) #7
Message was sent while issue was closed.
LGTM

https://codereview.chromium.org/1189643002/diff/1/src/typedarray.js
File src/typedarray.js (right):

https://codereview.chromium.org/1189643002/diff/1/src/typedarray.js#newcode147
src/typedarray.js:147: // Rephrase when they do.
I guess we cannot use shipping features until the flag is removed?

Powered by Google App Engine
This is Rietveld 408576698