Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/typedarray.js

Issue 1189643002: Avoid using computed property literals in TypedArrays code (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/typedarray.js
diff --git a/src/typedarray.js b/src/typedarray.js
index 812da32a96b14fc61a4907d767a22205b86e3702..2da7af0fa37e7f78ca79231fdc2a300b5e31640b 100644
--- a/src/typedarray.js
+++ b/src/typedarray.js
@@ -141,9 +141,11 @@ function NAMEConstructByIterable(obj, iterable, iteratorFn) {
// of modifications to Object.prototype being observable here.
var iterator = %_CallFunction(iterable, iteratorFn);
var newIterable = {
- __proto__: null,
- [symbolIterator]() { return iterator; }
+ __proto__: null
};
+ // TODO(littledan): Computed properties don't work yet in nosnap.
+ // Rephrase when they do.
arv (Not doing code reviews) 2015/06/16 16:41:04 I guess we cannot use shipping features until the
+ newIterable[symbolIterator] = function() { return iterator; }
for (var value of newIterable) {
list.push(value);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698