Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7202)

Unified Diff: chrome/browser/instant/instant_controller.h

Issue 11889003: Fixing ESC in instant-extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reverted back to asvitkine's fix. REALLY answered PK's comments. :) Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/instant/instant_controller.cc » ('j') | chrome/browser/instant/instant_page.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_controller.h
diff --git a/chrome/browser/instant/instant_controller.h b/chrome/browser/instant/instant_controller.h
index 1a08425b39423b7f64eba611099f18fa94b632fc..3478fe1947a91af421e0b9f9220df3d5fa2027f3 100644
--- a/chrome/browser/instant/instant_controller.h
+++ b/chrome/browser/instant/instant_controller.h
@@ -111,6 +111,11 @@ class InstantController : public InstantPage::Delegate {
// handled the key press.
bool OnUpOrDownKeyPressed(int count);
+ // Called when the user has arrowed into the selections but want to cancel,
sreeram 2013/02/12 18:12:29 selections -> suggestions want -> wants
beaudoin 2013/02/12 20:27:30 Done.
+ // typically by pressing ESC. The omnibox text is expected to have been
+ // reverted to |user_text| by Chrome prior to calling this.
sreeram 2013/02/12 18:12:29 Chrome -> the OmniboxEditModel
beaudoin 2013/02/12 20:27:30 Done.
+ bool OnCancel(string16 user_text);
sreeram 2013/02/12 18:12:29 const string16& The return value doesn't seem to b
beaudoin 2013/02/12 20:27:30 Done.
+
// The preview WebContents. May be NULL. InstantController retains ownership.
content::WebContents* GetPreviewContents() const;
« no previous file with comments | « no previous file | chrome/browser/instant/instant_controller.cc » ('j') | chrome/browser/instant/instant_page.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698