Fixing ESC in instant-extended.

chrome/browser/instant/instant_controller.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_INSTANT_INSTANT_CONTROLLER_H_
 #define CHROME_BROWSER_INSTANT_INSTANT_CONTROLLER_H_
 
 #include <list>
 #include <map>
 #include <string>
@@ skipping 93 matching lines @@
 
   // Send autocomplete results from |providers| to the preview page.
   void HandleAutocompleteResults(
       const std::vector<AutocompleteProvider*>& providers);
 
   // Called when the user presses up or down. |count| is a repeat count,
   // negative for moving up, positive for moving down. Returns true if Instant
   // handled the key press.
   bool OnUpOrDownKeyPressed(int count);
 
+  // Called when the user has arrowed into the selections but want to cancel,

[sreeram, 2013/02/12 18:12:29]

selections -> suggestions
want -> wants

[beaudoin, 2013/02/12 20:27:30]

Done.

+  // typically by pressing ESC. The omnibox text is expected to have been
+  // reverted to |user_text| by Chrome prior to calling this.

[sreeram, 2013/02/12 18:12:29]

Chrome -> the OmniboxEditModel

[beaudoin, 2013/02/12 20:27:30]

Done.

+  bool OnCancel(string16 user_text);

[sreeram, 2013/02/12 18:12:29]

const string16&
The return value doesn't seem to be used by OmniboxEditModel, so why not "void"?

[beaudoin, 2013/02/12 20:27:30]

Done.

+
   // The preview WebContents. May be NULL. InstantController retains ownership.
   content::WebContents* GetPreviewContents() const;
 
   // Returns true if the Instant preview is showing a search results preview.
   bool IsPreviewingSearchResults() const;
 
   // If the preview is showing search results, commits the preview, calling
   // CommitInstant() on the browser, and returns true. Else, returns false.
   bool CommitIfPossible(InstantCommitType type);
 
@@ skipping 264 matching lines @@
   // MODE_SEARCH_SUGGESTIONS, except in those cases where this is false.
   bool allow_preview_to_show_search_suggestions_;
 
   // List of events and their timestamps, useful in debugging Instant behaviour.
   mutable std::list<std::pair<int64, std::string> > debug_events_;
 
   DISALLOW_COPY_AND_ASSIGN(InstantController);
 };
 
 #endif  // CHROME_BROWSER_INSTANT_INSTANT_CONTROLLER_H_