Chromium Code Reviews Chromium Code Reviews
Issue 1188763002:
Click event should be fired before change events for checkbox and radio button. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/forms/radio-checkbox-events-order.html |
| diff --git a/LayoutTests/fast/forms/radio-checkbox-events-order.html b/LayoutTests/fast/forms/radio-checkbox-events-order.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..ed7708618f9adec61e20dd033630408ef01ff9ac |
| --- /dev/null |
| +++ b/LayoutTests/fast/forms/radio-checkbox-events-order.html |
| @@ -0,0 +1,103 @@ |
| +<!DOCTYPE HTML> |
| + |
| +<script src="../../resources/js-test.js"></script> |
| + |
| +<body> |
| +<input type="checkbox" id="checkbox-btn1" onclick="doClickAction(event)" onchange="doChangeAction(event)"/> |
| +<input type="checkbox" id="checkbox-btn2" onclick="doClickAction(event); event.preventDefault()" onchange="doChangeAction(event)"/> |
| +<input type="radio" id="radio-btn1" onclick="doClickAction(event)" onchange="doChangeAction(event)"/> |
| +<input type="radio" id="radio-btn2" onclick="doClickAction(event); event.preventDefault()" onchange="doChangeAction(event)"/> |
| +<script> |
| +description('Tests the order of onclick and onchange'); |
| +var message = ''; |
| + |
| +function doClickAction(e) |
| +{ |
| + shouldBeEqualToString('message', ''); |
| + message = 'clicked'; |
| +} |
| + |
| +function doChangeAction(e) |
| +{ |
| + shouldBeEqualToString('message', 'clicked'); |
| + message = 'changed'; |
| +} |
| + |
| +var checkbox1 = document.getElementById('checkbox-btn1'); |
| +var checkbox2 = document.getElementById('checkbox-btn2'); |
| +var radio1 = document.getElementById('radio-btn1'); |
| +var radio2 = document.getElementById('radio-btn2'); |
| + |
| +message = ''; |
| +checkbox1.click(); |
| +shouldBeEqualToString('message', 'changed'); |
| +shouldBeTrue('checkbox1.checked'); |
| + |
| +message = ''; |
| +checkbox1.click(); |
| +shouldBeEqualToString('message', 'changed'); |
| +shouldBeFalse('checkbox1.checked'); |
| + |
| +message = ''; |
| +checkbox2.click(); |
| +shouldBeEqualToString('message', 'clicked'); |
| +shouldBeFalse('checkbox2.checked'); |
| + |
| +message = ''; |
| +checkbox1.checked = false; |
| +checkbox1.focus(); |
| +eventSender.keyDown(' '); |
| +shouldBeEqualToString('message', 'changed'); |
| +shouldBeTrue('checkbox1.checked'); |
| + |
| +message = ''; |
| +checkbox1.focus(); |
| +eventSender.keyDown(' '); |
| +shouldBeEqualToString('message', 'changed'); |
| +shouldBeFalse('checkbox1.checked'); |
| + |
| +message = ''; |
| +checkbox2.checked = false; |
| +checkbox2.focus(); |
| +eventSender.keyDown(' '); |
| +shouldBeEqualToString('message', 'clicked'); |
| +shouldBeFalse('checkbox2.checked'); |
| + |
| +message = ''; |
| +radio1.click(); |
| +shouldBeEqualToString('message', 'changed'); |
| +shouldBeTrue('radio1.checked'); |
| + |
| +message = ''; |
| +checkbox1.focus(); |
|
tkent
2015/06/16 23:56:29
This line is confusing. I think this line should
Paritosh Kumar
2015/06/17 06:01:33
Removed. Thanks.
|
| +radio1.click(); |
| +shouldBeEqualToString('message', 'clicked'); |
| +shouldBeTrue('radio1.checked'); |
| + |
| +message = ''; |
| +radio2.click(); |
| +shouldBeEqualToString('message', 'clicked'); |
| +shouldBeFalse('radio2.checked'); |
| + |
| +message = ''; |
| +radio1.checked = false; |
| +radio1.focus(); |
| +eventSender.keyDown(' '); |
| +shouldBeEqualToString('message', 'changed'); |
| +shouldBeTrue('radio1.checked'); |
| + |
| +message = ''; |
| +radio1.focus(); |
| +eventSender.keyDown(' '); |
| +shouldBeEqualToString('message', ''); |
| +shouldBeTrue('radio1.checked'); |
| + |
| +message = ''; |
| +radio2.checked = false; |
| +radio2.focus(); |
| +eventSender.keyDown(' '); |
| +shouldBeEqualToString('message', 'clicked'); |
| +shouldBeFalse('radio2.checked'); |
| + |
| +</script> |
| +</body> |
